Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): pull main into develop post release v1.52.0 #2908

Merged
merged 8 commits into from
Dec 13, 2023
Merged

chore(release): pull main into develop post release v1.52.0 #2908

merged 8 commits into from
Dec 13, 2023

Conversation

devops-github-rudderstack
Copy link
Contributor

👑 An automated PR

web-flow and others added 8 commits December 12, 2023 09:33
@web-flow
chore(release): 1.52.0
b55feed
@abhimanyubabbar
fix(dm): dropped support of useClones for trackingplans cache (#2899)
439ba73 
* dropped support of useClones for trackingplans cache

* updated the changelog
@yashasvibajpai
chore: add stringtype check to escapehtml in adobe (#2900)
be20850
@sanpj2292
fix: braze transformation error due to wrong import (#2901)
90c725e
@yashasvibajpai @utsabc
chore: add lowercase check to MSL for event type audiencelist (#2904)
aad2480 
* chore: add lowercase check to MSL for event type audiencelist

* chore: fix optional chaining

Co-authored-by: Utsab Chowdhury <[email protected]>

* chore: update test

---------

Co-authored-by: Utsab Chowdhury <[email protected]>
@aashishmalik
fix: updated error response of v1 proxy (#2906)
7825c19
@ujjwal-ab
fix(reddit): add undefined check for eventsMapping field (#2905)
a606ec1 
feat: add undefined check for evensMapping field
@krishna2020
chore(release): pull release/v1.52.0 into main (#2898)
045f362
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 13, 2023

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@codecov Codecov
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 55 lines in your changes are missing coverage. Please review.

Comparison is base (981bae8) 87.19% compared to head (045f362) 87.27%.
Report is 22 commits behind head on develop.

Files Patch % Lines
src/v0/destinations/active_campaign/transform.js 12.50% 14 Missing ⚠️
src/controllers/delivery.ts 57.69% 11 Missing ⚠️
src/v0/util/errorTypes/transformerProxyError.js 35.71% 6 Missing and 3 partials ⚠️
...c/v0/destinations/marketo_static_list/transform.js 88.37% 5 Missing ⚠️
...v0/destinations/marketo_static_list/transformV2.js 92.53% 5 Missing ⚠️
src/services/delivertTest/deliveryTest.ts 0.00% 3 Missing ⚠️
src/services/destination/postTransformation.ts 81.25% 3 Missing ⚠️
src/util/openfaas/index.js 87.50% 1 Missing ⚠️
src/v0/destinations/adobe_analytics/utils.js 50.00% 1 Missing ⚠️
src/v0/destinations/reddit/networkHandler.js 96.15% 1 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2908      +/-   ##
===========================================
+ Coverage    87.19%   87.27%   +0.07%     
===========================================
  Files          776      790      +14     
  Lines        28943    29208     +265     
  Branches      6791     6830      +39     
===========================================
+ Hits         25237    25491     +254     
- Misses        3364     3373       +9     
- Partials       342      344       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
77.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@aashishmalik aashishmalik merged commit 6426b73 into develop Dec 13, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aashishmalik aashishmalik aashishmalik approved these changes

@krishna2020 krishna2020 krishna2020 approved these changes

@sivashanmukh sivashanmukh Awaiting requested review from sivashanmukh sivashanmukh is a code owner

@chandumlg chandumlg Awaiting requested review from chandumlg chandumlg is a code owner automatically assigned from rudderlabs/integrations

@anantjain45823 anantjain45823 Awaiting requested review from anantjain45823 anantjain45823 is a code owner automatically assigned from rudderlabs/integrations

@sanpj2292 sanpj2292 Awaiting requested review from sanpj2292

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@devops-github-rudderstack @krishna2020 @aashishmalik @web-flow @abhimanyubabbar @yashasvibajpai @sanpj2292 @ujjwal-ab